kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Do not discard auth command if no args

Open markusheiden opened this issue 2 years ago • 4 comments

Description

The authentication command (user.exec.args: command) from the .kube/config won't be discarded if no arguments are specified (user.exec.args: null).

Type of change

  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [x] Code contributed by me aligns with current project license: Apache 2.0
  • [x] I Added CHANGELOG entry regarding this change
  • [x] I have implemented unit tests to cover my changes
  • [x] I have added/updated the javadocs and other documentation accordingly
  • [x] No new bugs, code smells, etc. in SonarCloud report
  • [x] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

Fixes https://github.com/fabric8io/kubernetes-client/issues/3733 Backport for the 5.12 branch: https://github.com/fabric8io/kubernetes-client/pull/4122

markusheiden avatar May 05 '22 17:05 markusheiden

Due to problems in the master branch that are not related to this PR I was not able to test my code at all. How to progress?

markusheiden avatar May 05 '22 21:05 markusheiden

Due to problems in the master branch that are not related to this PR I was not able to test my code at all. How to progress?

Could you please elaborate on the problems?

manusa avatar May 11 '22 12:05 manusa

I tried again and it worked. Maybe I used the wrong JDK before.

markusheiden avatar May 11 '22 16:05 markusheiden

This issue was also tackled on #4381, I'll merge some of the changes in this PR into the other one and close it.

manusa avatar Sep 22 '22 09:09 manusa