kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Methods that accept a string such as inNamespace, withName, loclResourceVersion, and so on should consistently check the provided argument

Open manusa opened this issue 2 years ago • 3 comments

Description

Currently, we have different validations scattered around the methods that accept a single String argument such as inNamespace, withName, and so on.

We should be consistent and perform the same validation across the code-base. Ideally an Utils.isNotBlank method should be used for null, 0-length, or blank String check.


It can be - but we aren't doing that check with the other inNamespace, or other string name, locations. Ideally we would be consistent about not accepting empty / null anywhere a name was expected - so maybe a separate issue to cover that.

Originally posted by @shawkins in https://github.com/fabric8io/kubernetes-client/pull/4027#discussion_r848315325

manusa avatar Apr 12 '22 11:04 manusa

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

stale[bot] avatar Jul 25 '22 21:07 stale[bot]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

stale[bot] avatar Oct 25 '22 00:10 stale[bot]

Hi @manusa i would like to contribute to this issue , can you please assign this to me

aditya-32 avatar Apr 21 '23 19:04 aditya-32