kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Remove the need for the openshift-client dependency

Open shawkins opened this issue 3 years ago • 3 comments

There are things in the openshift client that prevent it from being an api only dependency. We'd have to refactor to account for:

  • Operations that contribute at the collection level, like ProjectOperations
  • Operations that read logs, there's no existing exposed method on Client for this.
  • the client logic that switches the httpclient / configuration to openshift specific. OpenShiftConfig, Readiness, and the OpenShiftOAuthInterceptor could all be moved to client to facilitate this.
  • OpenShiftNamespaceVisitFromServerGetWatchDeleteRecreateWaitApplicableListImpl - it's a whole other abstraction
  • CreateOnlyResourceOperationsImpl
  • ManagedOpenShiftClient

Originally posted by @shawkins in https://github.com/fabric8io/kubernetes-client/issues/3966#issuecomment-1075415793

shawkins avatar Mar 28 '22 18:03 shawkins

Is an open shift better process to be in ?

linnjason678 avatar Apr 04 '22 07:04 linnjason678

Is removing open shift better for the client,

linnjason678 avatar Apr 04 '22 07:04 linnjason678

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

stale[bot] avatar Jul 03 '22 07:07 stale[bot]

I believe there are still some actions to be taken in the scope of this issue.

manusa avatar Dec 12 '22 10:12 manusa

Marking as closed. There is too much refactoring to make this happen any time soon.

shawkins avatar May 01 '23 13:05 shawkins