Bulk format the entire codebase

[shawkins]

trafficstars

Is your task related to a problem? Please describe

To cut down on the amount of noise in PRs it would be good to bulk format everything now that we haven't seen additional issues with spotless.

Describe the solution you'd like

Bulk format everything. At worst the existing prs would need to be rebased, but generally the changes should be mergable.

Describe alternatives you've considered

No response

Additional context

No response

[stale[bot]]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!

[shawkins]

All we need to do for this is temporarily remove ratchetFrom in the root pom, then run "mvn spotless:apply -Pitests". Looks like about 619 files still need formatted. Once master switches to 6.1, I'll open a pr.

[manusa]

I'd personally dislike this since it interferes a lot with the work done when figuring out bugs and "bisecting" them. It's much easier for me to reformat a contributor's (who might struggle with formatting) active PR in a subsequent commit. Maybe we can further discuss

[shawkins]

Maybe we can further discuss

No problem. The primary driver is to make it easier to read pr diffs moving forward. Also given that we've had the formatting requirement in place for the better part of a major release, most high touch files have already been formatted - so we're just cleaning up at this point.

Yes it will make back porting fixes more difficult, but it seems like it's pretty infrequent that something needs back ported.

[manusa]

It seems like it's pretty infrequent that something needs back ported.

I hope you're right with this :sweat_smile: :wink:

[stale[bot]]

This issue has been automatically marked as stale because it has not had any activity since 90 days. It will be closed if no further activity occurs within 7 days. Thank you for your contributions!