kubernetes-client icon indicating copy to clipboard operation
kubernetes-client copied to clipboard

Update chaos mesh to v2.1.3

Open hypnoce opened this issue 2 years ago • 3 comments

Description

Type of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [X] Feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to change
  • [ ] Chore (non-breaking change which doesn't affect codebase; test, version modification, documentation, etc.)

Checklist

  • [X] Code contributed by me aligns with current project license: Apache 2.0
  • [X] I Added CHANGELOG entry regarding this change
  • [ ] I have implemented unit tests to cover my changes
  • [ ] I have added/updated the javadocs and other documentation accordingly
  • [ ] No new bugs, code smells, etc. in SonarCloud report
  • [ ] I tested my code in Kubernetes
  • [ ] I tested my code in OpenShift

hypnoce avatar Mar 14 '22 13:03 hypnoce

@iocanel I intentionally left this PR breaking the build. The problem is that one of the fields in the chaosmesh CRD has the name "class". While this works fine with jsonchema2pojo (rename to _class, getClass_ and setClass_), it breaks sundr. There are many ways to fix this, I wanted to get your feedback first.

hypnoce avatar Mar 14 '22 13:03 hypnoce

@oscerd @iocanel let me know how you prefer to move forward with this. Thanks

hypnoce avatar Mar 23 '22 14:03 hypnoce

Hi @hypnoce This PR never made it to the ready phase and is now quite updated. Are you still working on it?

manusa avatar Jul 28 '22 09:07 manusa

After https://github.com/fabric8io/kubernetes-client/pull/4358, the fix (extensions/chaosmesh) : Use hand written JVMChaosSpec and related classes should not be necessary. Please rebase and remove it.

manusa avatar Aug 29 '22 12:08 manusa