fabric8-pipeline-library
fabric8-pipeline-library copied to clipboard
Remove mutiple ways to get github token
I find that there are two ways to fetch github token in the pipeline library
-
withCredentials
to lookupcd-github
see: https://github.com/fabric8io/fabric8-pipeline-library/blob/0bff0f50a2af9a0dcc4d2c4abb28d1eafcbfdfb9/vars/mavenCI.groovy#L14 -
Fabric8Command.getGitHubToken
which uses a different mechanism. See: https://github.com/fabric8io/fabric8-pipeline-library/blob/0bff0f50a2af9a0dcc4d2c4abb28d1eafcbfdfb9/src/io/fabric8/Fabric8Commands.groovy#L838
Lets ensure there is only one way to do this.