fabric8-pipeline-library
fabric8-pipeline-library copied to clipboard
reduce logging of hubot
When I have a pipeline without any hubot configured I still see:
[Pipeline] hubotApprove
Hubot sending to room fabric8_default => Would you like to promote version 2.0.1 to the next environment?
to Proceed reply: fabric8 jenkins proceed job maxandersen/mirror/master build 1
to Abort reply: fabric8 jenkins abort job maxandersen/mirror/master build 1
No service hubot is running!!!
No service found!
Two things come to mind:
-
why does it even tell me about hubot when I don't have it running. I assume for many this would be the default and thus 9 lines of output is wasteful. If it must do something maybe only do 1 line like
Service hubot is not running!
-
shouldn't enable/disablement of features in the shared jenkins pipeline be something controlled by the user ? i.e. by the user enable/disabling extensions rather than it is defined in the world global:
github.com/fabric8io/fabric8-pipeline-library@master
?