configmapcontroller Adding support for Secrets

New Informer that listens/watches changes in secrets and triggers rolling updates in DaemonSets, Statefulsets and Deployments.

Mar 21 '18 16:03 lcnuance

I know historically cmc is missing tests; so, wondering how can we ensure code quality for such big changes without any tests?

secondly if we add "secrets update" to same controller then we should rename it to something different

Mar 26 '18 21:03 rasheedamir

It's a good idea to add some automated tests. I only tested manually but perhaps we could create a helm chart and do helm test. We could test happy path for each element and may be some raise conditions.

Mar 28 '18 13:03 lcnuance

If tests don't exist for the whole project, I don't see the point why a PR should be blocked for missing tests.

Apr 03 '18 12:04 joekohlsdorf