launcher-application icon indicating copy to clipboard operation
launcher-application copied to clipboard

Published 20 hours ago • verified publisher icon fabric8-launcher

Add "Branch" edit box to import card

Open quintesse opened this issue 6 years ago • 4 comments

It would be great to have a place to type the name of the Git branch below or next to the place where you can enter the URL. By default it would be master, but you would be allowed to type any other name there. This value would then be passed to the /import/analyze and /import/launch endpoints as gitImportBranch.

Extra points if we could make it a dropdown with the result from the /import/branches endpoint (this only takes a gitImportUrl value and returns a list of branch names). But I can imagine that's too much work for tomorrow (Friday 29th, the day we have to release).

quintesse avatar Mar 29 '19 00:03 quintesse

Right: or "ref", which can be any valid ref like a tag or SHA. Exactly.

ALRubinger avatar Mar 29 '19 03:03 ALRubinger

(Consider it part of "not the train we just did") - continuous pushing new features is fine!

ALRubinger avatar Mar 29 '19 03:03 ALRubinger

@ALRubinger yeah, they're really called refs, but I took the name from the option that's being used in the git clone command itself: it uses --branch and then says in the docs that it also allows tag names.

quintesse avatar Mar 29 '19 11:03 quintesse

Taking usability hints from the git command-line client HAHAHAHAHAHA thanks there buddy I needed a laugh.

ALRubinger avatar Mar 29 '19 13:03 ALRubinger