fable-react icon indicating copy to clipboard operation
fable-react copied to clipboard

Published 20 hours ago • verified publisher icon fable-compiler

JustifyContent should be made type safe just like AlignItems

Open MangelMaxime opened this issue 5 years ago • 2 comments

MangelMaxime avatar Apr 01 '19 07:04 MangelMaxime

It seems like a lot of CSSProps are typed by an obj or a string where they could benefit from more type safety. Is there a reason why they're not typed by a DU, for example?

jannesiera avatar Aug 22 '19 22:08 jannesiera

It's because of Fable.React is one of the older libraries and at the time, we wanted to have a thin layer on top of React. So using obj make it easy to do that because the user can write center, 2px, calc(100vh - 3em), etc.

We are also a small team of core maintainer and can't do all the evolution ourself :)

Because we accepted making some of the properties type-safe, we would accept a PR converting more properties to be type-safe :)

MangelMaxime avatar Aug 23 '19 07:08 MangelMaxime