fable-import icon indicating copy to clipboard operation
fable-import copied to clipboard

Update electron to Fable.Core 3

Open cmeeren opened this issue 5 years ago • 4 comments

Could the Electron bindings be updated to Fable.Core 3? It's currently blocking a big update in cmeeren/fable-elmish-electron-material-ui-demo for Fable.Core 3 / Fable.React 5 compat/demo.

(Btw, the bindings are for Electron 0.37.7 and the most recent Electron version is 5.0, but that's another matter - they seem to work fine for Electron 4 as far as I've used them in the repo I mentioned.)

cmeeren avatar May 03 '19 16:05 cmeeren

As we're deprecating this repo, we'll have to move the Electron bindings to their own repo. I can do that an update everything to Fable.Core 3, but after that one or more volunteers would be needed to maintain the repository (ideally people that actually use Fable with Electron).

alfonsogarciacaro avatar May 06 '19 09:05 alfonsogarciacaro

Gotcha. I would like to say I can do it, but unfortunately I don't have the capacity to properly maintain something like that for the time being. At the moment it would just add to my stress levels to simply have that passive responsibility.

But if you can separate it out into its own repo and at least get the basic stuff in place (and clearly call for maintainers in the readme or something like that, and probably briefly describe the current state of the repo), it'll be much easier for interested parties to take over. :)

It's possible I may be able/interested in the future if no-one else has taken over, but no promises.

Perhaps F# weekly can be a channel to call for maintainers?

cmeeren avatar May 06 '19 09:05 cmeeren

Ok, I did it here :) I fixed the build errors and use a project structure similar to recent packages. But the bindings are very old and I'm not sure how usable they are. We would need somebody willing to use Fable with Electron and help others in the process :)

alfonsogarciacaro avatar May 07 '19 10:05 alfonsogarciacaro

Great, thanks! Did you publish to nuget, too?

By the way, the existing bindings work with Electron 4 as far as I've tested them (not much, but the app runs without problems, and I can open save/load file dialogs).

cmeeren avatar May 07 '19 10:05 cmeeren