Fable icon indicating copy to clipboard operation
Fable copied to clipboard

Format specifies don't seem to be fully implemented

Open zelenij opened this issue 3 years ago • 1 comments

Description

Format specifies don't seem to be fully implemented. Specifically, thousands separator is not applied

Repro code

https://fable.io/repl/#?code=PYBwpgdgBAygngZwC5gLYFgBQpJQGICGARgDZgB0AwsAE5hY7SGkXV3kBSCAkhCjaCxYA2gB4AoqgCWSABQAiAO5SIAE2CLyBMjTkASAAwBKeUYB8AXSxkkUbWF1RZqMAgQEA5mABcUZDRUPI18AVwgZKABeKAArBAA5AiQpADd6TBsoADNaVCSnBF88XKSkYjIYJACIIKjYRBRUckrqj3Jimjy5BHaSpAAaP3IAcTAkAEEaDxCXPgRZIyMhDLGoVSksrLqARgM9rHtHWRzO-L15AG91ze94gFYAXzWCRDsPYFMsIA&html=Q&css=Q

Expected and actual results

Expected: 1,000 Actual: 1000

Related information

  • Fable version: dotnet fable --version
  • Operating system

zelenij avatar Nov 01 '21 08:11 zelenij

Supporting all format specifiers is quite complicated and we're doing it bit by bit 😸 You can check which formats are supported in the String tests. In one of the latest releases we added support for thousand separators with the #,## pattern: https://github.com/fable-compiler/Fable/blob/b8971666bcc3e464072db23f776baf515d6c8126/tests/Main/StringTests.fs#L352-L360

If you need something in particular, could you please provide a test like the linked one with the expected results in .NET. Thank you very much!

alfonsogarciacaro avatar Jan 07 '22 05:01 alfonsogarciacaro