Fable
Fable copied to clipboard
fable-compiler
Fix for #1593 added some date tostring options
Needs some test cases and some testing. I haven't even built fable yet because I've not gotten that far yet but this is where I am right now.
Thanks for your PR @voronoipotato! Maybe we don't need to close it in full, what's in the PR, only localization? I think it'll be difficult to support Globalization as in .NET because it's quite a big amount of work and that may increase the bundle sizes. For the same reasons, I'd prefer to avoid external dependencies in fable-core (like moment-js), but we can discuss about that.
I'll reopen for now to see if anything may be useful. I wouldn't say that it was "for" globalization but rather some of the formatting does not take into consideration other cultures. The goal I had in doing this PR was to make copy pasting F# into fable just a little bit easier but I did have concerns about it only being useful for westerners potentially mostly for Americans (I know very little about other cultures).
I added tostring options with the intention of improving compatibility with Core. I added (f: milliseconds) , (t: AM/PM), dddd Weekdays (english), ddd Weekdays Short (english), mmmm Months (english), mmm Months Short (english), in addition I added several single letter tostring options. d,D,f,F,g,G,m,M,t,T,U . The single letter ToString format for dates exists as a convenience and allows the user to quickly format a date in a useful way. Date.ToString("d") for example is equivalent to Date.ToString("M/d/yyyy") however you can see how this may be less useful for someone who doesn't use middle endian dates. There definitely are bits that would require no localization, and many of these are the default if I'm not mistaken in .Net, which wouldn't surprise me given that the Microsoft is an American company. However I am an American, and have never programmed anything in .Net that needed localization so I'm not exactly any authority on the subject.
Perhaps later we can move all the date stuff into Date.ts, since Util.ts is getting quite big.
A few tests to cover the new options will go a long way. "A test a day keeps the doctor away."
Hi @voronoipotato! What's the status of this? Will you include some tests to see what the PR is trying to solve? Thank you!
This isn't needed anymore is it? I am dumb as bricks and missed the ping for a few years now.
This PR being quite old I think we can close it for now.
There is https://github.com/fable-compiler/Fable/issues/3692 which tracks the task to improve supported format for DateTime. If someone want to revive it then can either adapt the original mscord code or take inspiration from this PR too.
