vscode-highlight icon indicating copy to clipboard operation
vscode-highlight copied to clipboard

Dark vs light theme support

Open danielfaust opened this issue 1 year ago • 1 comments

Assume that

"highlight.regexes": {
  "(//TODO)(:)": [
    { "color": "yellow" },
    { "color": "white" }
  ]
}

works good for dark themes, but I want to temporarily use a light theme. Then yellow and white would no longer be a good choice, but rather

"highlight.regexes": {
  "(//TODO)(:)": [
    { "color": "orange" },
    { "color": "black" }
  ]
}

Could there be a way to specify

"highlight.regexes.dark": { <--------
  "(//TODO)(:)": [
    { "color": "yellow" },
    { "color": "white" }
  ]
}

and

"highlight.regexes.light": { <--------
  "(//TODO)(:)": [
    { "color": "orange" }
    { "color": "black" }
  ]
}

or more concise

"highlight.regexes": {
  "(//TODO)(:)": {
    "dark": [
        { "color": "yellow" },
        { "color": "white" }
    ],
    "light": [
        { "color": "orange" },
        { "color": "black" }
    ]
  }
}

in order to support this?

danielfaust avatar Sep 02 '24 17:09 danielfaust

related https://github.com/fabiospampinato/vscode-highlight/pull/62

dimateos avatar Feb 27 '25 20:02 dimateos