Fabio Perrella comments

Results 18 comments of


                                            Fabio Perrella

redirection-mobile-self javascript error

Return a more uniform structure in as_json

After trying yo use the new version with `stringify_keys:true` in our service, we realized it wasn't enough 😞 . When the hash has non-strings as values, it raises errors like...

Return a more uniform structure in as_json

I always prefer to keep compatible when possible! 😄 `use_strings` seems good for me! So, I will open another PR here and close https://github.com/WeTransfer/peek/pull/127

Return a more uniform structure in as_json

I realized the problem with `JSON.dump(result)` (source sequence is illegal/malformed utf-8) happens when the result hash contains non utf-8 strings inside. For example, when the filename is something like `"foo\xA9s"`

Upgrade faraday dependency

Thank you @ljachymczyk for your contribution!

Upgrade faraday dependency

I see that the tests are failing for old Rubies. What about dropping support for EOL Rubies? ``` # format_parser.gemspec spec.required_ruby_version = Gem::Requirement.new(">= 2.6.0") ``` Also changing the matrix on...

Make gem releasable without bundling

@rhruiz what about adding something about `docker-release.sh` in README?

Allow multiple hosts filtering

Collection parsing raises an error if the value is nil

cc @BCecatto

Collection parsing raises an error if the value is nil

Hey @maxemitchell , sorry, but I'm currently completely out of this context and I can't help you with this