django-admin-interface icon indicating copy to clipboard operation
django-admin-interface copied to clipboard

Left/right scrolling broken with django-import-export

Open yatahaze opened this issue 1 year ago • 7 comments

I'm not sure which repo to open this issue on, but when using django-import-export, after importing it takes you to a big table that shows the before & after. With this theme enabled, there is no ability to scroll left and right to see those changes.

Issue on the other side, just in case: https://github.com/django-import-export/django-import-export/issues/1476

yatahaze avatar Jul 26 '22 20:07 yatahaze

Hello @yatahaze thanks for reporting this, have you any public demo for checking the issue quickly?

fabiocaccamo avatar Jul 27 '22 05:07 fabiocaccamo

Unfortunately I do not, but i could save html from a project of mine if that would help? Or I could inspect the code but I'm not sure what I'd be looking for...

yatahaze avatar Jul 27 '22 22:07 yatahaze

@yatahaze maybe just the html page is enough to debug the css quickly. I think a specific overflow css rule could easily solve this.

fabiocaccamo avatar Jul 28 '22 07:07 fabiocaccamo

@yatahaze have you found a CSS fix for this overflow issue? There is surely some django-import-export css class that can be used to fix this.

fabiocaccamo avatar Aug 25 '22 10:08 fabiocaccamo

@yatahaze have you found a CSS fix for this overflow issue? There is surely some django-import-export css class that can be used to fix this.

I do! Is there a way I can send it to you privately in case there's something revealing in it?

yatahaze avatar Aug 25 '22 15:08 yatahaze

@yatahaze sure, my email is public on my profile page.

fabiocaccamo avatar Aug 25 '22 16:08 fabiocaccamo

Sent!

yatahaze avatar Aug 25 '22 17:08 yatahaze

@yatahaze sorry for the late feedback.

What you sent me via email is not enough for debugging this problem, you should:

  • Go to the admin page where there is the problem
  • Save the admin page with the problem (saving the page you should have an html file and a directory containing all the assets used by the page)
  • Zip the page and the assets folder and send them with me via email

fabiocaccamo avatar Oct 06 '22 12:10 fabiocaccamo

OHHH! I actually didn't know the folder was included! I assumed I had to find some sort of extension to help, haha. I'll work on getting another test run going and send you all the files this time :)

yatahaze avatar Oct 06 '22 16:10 yatahaze

Fixed in de2979219e4fcf892bd76cba0dd192fa5e0ad5bd

fabiocaccamo avatar Oct 07 '22 09:10 fabiocaccamo

@yatahaze how did you added this?

Screenshot 2022-10-07 at 11 20 54

fabiocaccamo avatar Oct 07 '22 09:10 fabiocaccamo

Good question. I thought it was part of your theme?

Apparently it's from core Django.

yatahaze avatar Oct 07 '22 15:10 yatahaze

It's probably a new django feature, didn't know about it!

fabiocaccamo avatar Oct 07 '22 15:10 fabiocaccamo

Is that a filter for list filters??

Haven’t seen anything about that in 4.0 or 4.1 release notes. Can you share the admin config for this? (and your installed apps to see if it isn’t something third-party)

merwok avatar Oct 07 '22 15:10 merwok

The filter is only for the sidebar on the left side of the screen to narrow down the list of models. It's not super useful because the headers stay behind after filtering. So if you have a lot of apps you still have to scroll a ton. (Maybe that could be fixed with this theme? :smiley:)

yatahaze avatar Oct 07 '22 16:10 yatahaze

@merwok it's a filter for the apps, already in my plans.

fabiocaccamo avatar Oct 07 '22 16:10 fabiocaccamo