chocolate_duke3D
chocolate_duke3D copied to clipboard
Possible file handle leak in gamedef.c
void copydefaultcons(void)
{
long i, fs, fpi;
FILE *fpo;
for(i=0;i<3;i++)
{
fpi = TCkopen4load(defaultcons[i],1);
fpo = fopen( defaultcons[i],"wb");
if(fpi == 0)
{
// CTW - MODIFICATION
// if(fpo == -1) fclose(fpo);
if(fpo == NULL) fclose(fpo);
// CTW END - MODIFICATION
continue;
}
//...
}
The line:
if (fpo == NULL) fclose(fpo);
does not close fpo properly, causing a file handle leak when fpi == 0.