kirby-markdown-field icon indicating copy to clipboard operation
kirby-markdown-field copied to clipboard

[K4] 4.0 Compatibility

Open afbora opened this issue 2 years ago • 18 comments
trafficstars

Cannot read properties of undefined (reading 'map') Cannot read properties of undefined (reading 'page')

fields:
  text:
    type: markdown

Also you'll see some icons deprecated when you check browser console:

Deprecated: Custom icon "horizontal-rule" seems to use a 16x16 viewbox which has been deprecated. In an upcoming version, Kirby will only support custom icons with a 24x24 viewbox by default. If you want to continue using icons with a different viewport, please wrap them in an element with the corresponding viewBox attribute.

Deprecated: Custom icon "special-chars" seems to use a 16x16 viewbox which has been deprecated. In an upcoming version, Kirby will only support custom icons with a 24x24 viewbox by default. If you want to continue using icons with a different viewport, please wrap them in an element with the corresponding viewBox attribute.

Kirby 4.0.0-beta.1 (v4/develop branch)

afbora avatar Sep 20 '23 08:09 afbora

Is there a v4-compatible version on the horizon? This is one of my most precious plugins :)

animaux avatar Oct 23 '23 13:10 animaux

@animaux That currently depends on my availability. Still drowning in client work, but should be possible to wokr on that soon.

fabianmichael avatar Oct 26 '23 14:10 fabianmichael

Thanks for your heads-up! I can totally relate :).

animaux avatar Oct 26 '23 14:10 animaux

@fabianmichael 3.0.0 Alpha looks great so far, many thanks!

Only minor cosmetic things:

  • Text size is bigger compared with a textarea field (maybe on purpose?)
  • Icon for hr looks more like »space between paragraphs«

markdown field followed by a textarea field:

Bildschirmfoto 2023-11-30 um 08 22 18

hr icon:

Bildschirmfoto 2023-11-30 um 08 22 44

animaux avatar Nov 30 '23 07:11 animaux

@animaux Thanks for your feedback, I hope Alpha 2 fixes these issues: https://github.com/fabianmichael/kirby-markdown-field/releases/tag/3.0.0-alpha.2

fabianmichael avatar Nov 30 '23 09:11 fabianmichael

That was quick! Looks perfect now, many thanks!

animaux avatar Nov 30 '23 09:11 animaux

Just updated to 3.0.0-alpha.2 - it works for me as well without issues. Thanks 👍.

(Originally published at: https://srijan.ch/notes/2023-11-30-002)

srijan avatar Nov 30 '23 18:11 srijan

hey, any updates?

tobimori avatar Feb 05 '24 20:02 tobimori

not yet, things are still a bit messy around here … but nothing to worry about, this is still on my to do list.

fabianmichael avatar Feb 07 '24 21:02 fabianmichael

Edit: This is fixed when installing dev-main and not 3.0-alpha.2.


Weird bug I noticed, as soon as I have a blockquote inside my Markdown field, hrs aren't rendering correctly. With blockquote:

CleanShot 2024-02-09 at 17 19 00@2x

Without:

CleanShot 2024-02-09 at 17 19 19@2x

tobimori avatar Feb 09 '24 16:02 tobimori

I've noticed a pagination issue on any blueprint panel page that uses Markdown 2.2. Is this on your radar to look at? Clients still love your editor versus the regular textarea editor, so thanks!

luxuryluke avatar Feb 18 '24 23:02 luxuryluke

@fabianmichael sorry to nag, but is there a chance that we will see a 3.0.0 release in the near future, incorporating the fixes from the 2.x branch? Almost all my kirby sites rely on this extension and with the current problems I need to deactivate the link-button, which is annoying for my clients. Of course I appreciate your workload, let us know if there is anything we can do to help, though I’m afraid my skills regarding kirby extensions are fairly limited :|.

animaux avatar Apr 23 '24 08:04 animaux

OK. Using the current main branch (as @tobimori suggested somewhere eles) fixes the deleted text issue which is nice. And I was able to dumbhack myself through the code good enough to figure out how to replace the link-field with a standard-text-field in the link creation dialog in /src/components/Buttons/Link.js

href: {
	label: window.panel.$t("link"),
	// type: "link",
	type: "text",
	placeholder: window.panel.$t("url.placeholder"),
	help: "<b>Weblink:</b> https://beispiel.de<br/><b>Interner Link:</b> 	/hauptseite/unterseite/<br/><b>E-Mail:</b> mailto:[email protected]",
	icon: "url"
},

This is exacly what I need just now, so I’m happy for the moment. If this was an option in the future, that would be nice, but no hurries ;).

animaux avatar Apr 23 '24 10:04 animaux

@animaux Sorry that it takes so long. I am currently doing the final touches on my meta plugin and after that, the markdown field will finally be updated.

fabianmichael avatar Apr 23 '24 10:04 fabianmichael

I can totally understand. Thanks for your excellent work Fabian!

animaux avatar Apr 23 '24 10:04 animaux

Hey @fabianmichael any news on when work will continue on this? For the most part the alpha release works well, so hoping it won't be too painful for you. :)

kevquirk avatar Jun 27 '24 12:06 kevquirk