woof icon indicating copy to clipboard operation
woof copied to clipboard

A_RemoveFlags doesn't work properly sometimes

Open rfomin opened this issue 1 year ago • 7 comments

Bug report: [doomworld] Test WAD: unfix_that.zip From my tests, this WAD works differently in the latest versions of DSDA-Doom and Woof. Works if revert 1d27148032e5078ed56dd15c53eebaa309618a4e

rfomin avatar Jan 25 '25 13:01 rfomin

I think the issue is size of this map, blockmap is 342x241. See: https://github.com/kraflab/dsda-doom/blob/9980aed705d1fdddbdef3672f8ae806ce7c869e0/prboom2/src/p_setup.c#L3030-L3034

rfomin avatar Jan 25 '25 14:01 rfomin

The blockmap expansion code was requested to add in #759.

fabiangreffrath avatar Jan 25 '25 15:01 fabiangreffrath

Not sure if this test map works at all. What is the maximum size of Doom map, unsigned short? Test map size is 43648x30768

rfomin avatar Jan 25 '25 15:01 rfomin

I've made smaller version: unfix.zip Now it works in DSDA-Doom 0.27.5 and Woof 14.5.0, but it does not work in the most recent versions.

rfomin avatar Jan 25 '25 16:01 rfomin

@fabiangreffrath Do you know why we need https://github.com/fabiangreffrath/woof/commit/1d27148032e5078ed56dd15c53eebaa309618a4e?

rfomin avatar Jan 25 '25 16:01 rfomin

This is the discussion behind it:

https://github.com/kraflab/dsda-doom/pull/504

fabiangreffrath avatar Jan 25 '25 16:01 fabiangreffrath

Thanks, I forgot. Hmm, so we do need a new comp_ flag after all? I wonder why test WAD doesn't work, looks good to me.

rfomin avatar Jan 25 '25 17:01 rfomin