woof icon indicating copy to clipboard operation
woof copied to clipboard

add binding of config variables

Open rfomin opened this issue 2 months ago • 3 comments

A system like in Chocolate Doom for config variables, so we can potentially reduce the number of global variables and achieve better "encapsulation". I also think it's more convenient to bind config variables in a module rather than in m_config.c.

Should I continue?

rfomin avatar May 02 '24 09:05 rfomin

I like this approach, but how dows it help to reduce the number of global variables?

fabiangreffrath avatar May 02 '24 11:05 fabiangreffrath

I like this approach, but how dows it help to reduce the number of global variables?

Theoretically, we could make all sound module variables static and remove them from the .h files. The same applies to the video and input variables.

rfomin avatar May 02 '24 11:05 rfomin

Ah, right!

fabiangreffrath avatar May 02 '24 11:05 fabiangreffrath

Maybe I overdid it. @fabiangreffrath What do you think?

rfomin avatar May 07 '24 01:05 rfomin

What do you mean? Well, the patch is super invasive, but we knew that before, but the implementation is as clean as it can get.

fabiangreffrath avatar May 07 '24 06:05 fabiangreffrath

Should we now let @MrAlaux review the cvar descriptions?

Yes, sure.

rfomin avatar May 07 '24 11:05 rfomin