valibot icon indicating copy to clipboard operation
valibot copied to clipboard

Incorrect ISO 639-1 code for Korean language

Open yslpn opened this issue 3 months ago • 4 comments

I noticed that the language code for Korean is currently listed as kr, but this is not correct.

According to the ISO 639-1 standard, the correct two-letter code for Korean is ko. (kr is a country code for South Korea in ISO 3166, not a language code.)

Reference: https://en.wikipedia.org/wiki/ISO_639-1

Contributors of https://github.com/fabian-hiller/valibot/pull/429

@dodok8 @baekrang256 @2paperstar

Can you confirm this?

yslpn avatar Aug 24 '25 10:08 yslpn

Hi @yslpn! I'm Dosu and I’m helping the valibot team.

You are correct: the ISO 639-1 code for Korean is "ko", not "kr". The Valibot codebase currently uses "kr" for Korean in the i18n package (see the file packages/i18n/src/kr.ts), which is incorrect—"kr" is a country code, not a language code according to ISO 639-1 standards. This should be updated to "ko" to align with the standard source.

To reply, just mention @dosu.


How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other  Chat with Dosu Join Discord Share on X

dosubot[bot] avatar Aug 24 '25 10:08 dosubot[bot]

Yes actually ko is Korean language code

2paperstar avatar Aug 24 '25 10:08 2paperstar

@fabian-hiller Let's not consider changing the language code as a breaking change?

yslpn avatar Aug 24 '25 11:08 yslpn

Seems like we are currently using the country code instead of the language code. If it's not too complicated we could rename it but keep kr and mark it as deprecated.

fabian-hiller avatar Aug 24 '25 12:08 fabian-hiller