modular-forms icon indicating copy to clipboard operation
modular-forms copied to clipboard

[ESM Compliance] Add import file extensions

Open sachaw opened this issue 1 year ago • 3 comments

Hi, would you be open to a bringing this package in-compliance with the ESM spec, all that's required to to add import and export file extensions. This currently blocks usage of the modern node module resolution algorithm for projects that wish to use it. I can include commits for the other packages if you are happy with the changes.

Thanks.

sachaw avatar Dec 17 '23 04:12 sachaw

Deploy Preview for modularforms failed.

Name Link
Latest commit ee523bcbb95ea22b3087a5b3f261cba83a643b20
Latest deploy log https://app.netlify.com/sites/modularforms/deploys/657e75893b262b0008896236

netlify[bot] avatar Dec 17 '23 04:12 netlify[bot]

Thanks for creating this PR. I plan to rewrite Modular Forms in January. I will add the file extensions then. Would it help you to merge this PR before?

fabian-hiller avatar Dec 17 '23 16:12 fabian-hiller

I'm happy to wait out, glad to hear you have greater plans for this library. Up to you if you want to merge.

sachaw avatar Dec 18 '23 04:12 sachaw