gatsby-universal icon indicating copy to clipboard operation
gatsby-universal copied to clipboard

Update to react 16.8?

Open dante-blitz opened this issue 5 years ago • 8 comments

Hi there,

Thanks for your great starter.

Do you have any plans to update react to 16.8? I'm keen to experiment using material-ui v4 with your starter but it requires 16.8. I tried updating packages myself but they broke everything.

dante-blitz avatar May 09 '19 14:05 dante-blitz

Hey @dante-blitz, you should be able to update React by running yarn add react react-dom. I also updated it on the master branch now. If it still doesn't work, delete the node_modules folder and reinstall the dependencies again with yarn install.

fabe avatar May 09 '19 14:05 fabe

Thank for the info @fabe.

I just tried to update again. Here are the steps I took after cloning this repo:

  1. yarn add react-dom
  2. yarn develop

I get the following error message:

Error: Failed to process image ...content/images/gallery/react-context.jpg

dante-blitz avatar May 09 '19 15:05 dante-blitz

Did it work before you updated? And did you update both react and react-dom?

fabe avatar May 09 '19 16:05 fabe

Actually it doesn't work before the update. same issue.

dante-blitz avatar May 09 '19 16:05 dante-blitz

Running on Windows 10.

dante-blitz avatar May 09 '19 16:05 dante-blitz

Here is the full error message:

error UNHANDLED REJECTION

Error: Failed to process image .../content/images/gallery/react-context.jpg

(sharp:1391): GLib-CRITICAL **: 17:30:36.920: g_hash_table_lookup: assertion 'hash_table != NULL' failed
(sharp:1391): GLib-CRITICAL **: 17:30:37.427: g_hash_table_lookup: assertion 'hash_table != NULL' failed
(sharp:1391): GLib-CRITICAL **: 17:30:37.779: g_hash_table_lookup: assertion 'hash_table != NULL' failed
error Command failed with exit code 1.

dante-blitz avatar May 09 '19 16:05 dante-blitz

Difficult to debug from here, but I'm pretty sure this is not an issue with this starter itself. There's a similar issue that suggests you to update yarn (either by curl --compressed -o- -L https://yarnpkg.com/install.sh | bash or brew upgrade yarn). Maybe try that, together with removing the yarn.lock.

Alternatively, you can try reinstalling everything with npm install.

fabe avatar May 09 '19 16:05 fabe

tried. all options you suggested but the issue still persists.

I'll explore the issue myself and see if I can get to the bottom of it.

dante-blitz avatar May 09 '19 17:05 dante-blitz