snirf icon indicating copy to clipboard operation
snirf copied to clipboard

Added ICNNA to snirf supporting software list

Open forihuelaespina opened this issue 1 year ago • 8 comments

Added ICNNA to snirf supporting software list

forihuelaespina avatar Feb 26 '24 09:02 forihuelaespina

@forihuelaespina can you please add forihuelaespina to https://github.com/fNIRS/snirf/blob/master/.github/workflows/wordlist.txt ? Thanks!

Horschig avatar Feb 26 '24 13:02 Horschig

@forihuelaespina can you make the change to the wordlist so that your pull request passes the spell check. This pull request is in limbo until you do that.

dboas avatar Mar 28 '24 14:03 dboas

@forihuelaespina please could you update as requested by @dboas then we will get this merged?

samuelpowell avatar Apr 17 '24 15:04 samuelpowell

With my apologies for the delay. This has now been attended.

forihuelaespina avatar Apr 17 '24 22:04 forihuelaespina

~~@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).~~

Disregard above. I do not know why this is not passing, any ideas?

samuelpowell avatar Apr 18 '24 06:04 samuelpowell

~@forihuelaespina unsure why this is failing, but there is extraneous whitespace at the end of your addition to the wordlist. Could you update (and just in case, leave e.g. a trailing newline if one was present on master).~

Disregard above. I do not know why this is not passing, any ideas?

Not sure, the trailing white space is the only thing that would come to mind also.

Horschig avatar Apr 18 '24 07:04 Horschig

I've now removed the trailing space but left the trailing lines just in case. Whether this is what is preventing the update or not, I do not know.

forihuelaespina avatar Apr 18 '24 14:04 forihuelaespina

@Horschig can you approve review also?

samuelpowell avatar Apr 18 '24 14:04 samuelpowell