Mix-Wave-U-Net icon indicating copy to clipboard operation
Mix-Wave-U-Net copied to clipboard

Suggest to loosen the dependency on sacred

Open Agnes-U opened this issue 2 years ago • 0 comments

Hi, your project Mix-Wave-U-Net(commit id: 43304ef10db75a2f37c7290b576a696d123ed19a) requires "sacred==0.8.1" in its dependency. After analyzing the source code, we found that the following versions of sacred can also be suitable, i.e., sacred 0.8.0, since all functions that you directly (2 APIs: sacred.experiment.Experiment.init, sacred.ingredient.Ingredient.init) or indirectly (propagate to 26 sacred's internal APIs and 16 outsider APIs) used from the package have not been changed in these versions, thus not affecting your usage.

Therefore, we believe that it is quite safe to loose your dependency on sacred from "sacred==0.8.1" to "sacred>=0.8.0,<=0.8.1". This will improve the applicability of Mix-Wave-U-Net and reduce the possibility of any further dependency conflict with other projects.

May I pull a request to further loosen the dependency on sacred?

By the way, could you please tell us whether such an automatic tool for dependency analysis may be potentially helpful for maintaining dependencies easier during your development?

Agnes-U avatar Dec 13 '22 04:12 Agnes-U