vscode-f5 icon indicating copy to clipboard operation
vscode-f5 copied to clipboard

Post as CF function Does not return the response

Open CarlB-dev opened this issue 3 years ago • 4 comments

code server version 4.4.0 with The F5 Extension v3.7.1 When highlighting a JSON Payload and right clicking to use the POST AS CF function, the response message is not displayed. Example payload

{
        "class": "Cloud_Failover",
        "environment": "gcp",
        "externalStorage": {
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            }
            
        },
        "failoverAddresses": {
            "enabled":true,
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            }
        },
        "controls": {
            "class": "Controls",
            "logLevel": "silly"
        }
    
}

Output shows that the declaration was accepted and responded with a 200.

 222 [2022-06-02T16:21:33.390Z] [INFO]: HTTPS-REQU [zdqq]: get -> https://35.237.73.21:443/mgmt/shared/cloud-failover/declare
 223 [2022-06-02T16:21:33.517Z] [INFO]: HTTPS-RESP [zdqq]: 200 - OK 

However there is no JSON response body returned to VSCODE.

When the JSON payload is altered as follows, and I choose the Make HTTP Request, I get the JSON response:

{
    "url": "/mgmt/shared/cloud-failover/declare",
    "method": "POST",
    "body": {
        "class": "Cloud_Failover",
        "environment": "gcp",
        "externalStorage": {
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            }
            
        },
        "failoverAddresses": {
            "enabled":true,
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            }
        },
        "controls": {
            "class": "Controls",
            "logLevel": "silly"
        }
    }
}

JSON response

{
    "message": "success",
    "declaration": {
        "class": "Cloud_Failover",
        "environment": "gcp",
        "externalStorage": {
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            }
        },
        "failoverAddresses": {
            "enabled": true,
            "scopingTags": {
                "f5-cfe-failover-label": "student0"
            },
            "requireScopingTags": false
        },
        "controls": {
            "class": "Controls",
            "logLevel": "silly"
        },
        "schemaVersion": "1.11.0"
    }
}

CarlB-dev avatar Jun 02 '22 16:06 CarlB-dev

Hi Carl, this was by design to help reduce the amount of noise in the workflow. If things were successful, then I saw no need to make another window to disrupt the users workflow. If things failed, then it should provide the output for visibility with a new tab json response.

Can you help me understand what you are needing here? Do you need the whole json to be able to repost, or can we just log some of the response to provide the feedback your looking for?

DumpySquare avatar Jun 24 '22 17:06 DumpySquare

Ben, I understand your reasoning, however that is a change in behavior from every other part of the ATC within the extension. Another change in behavior/functionality is that when you click on the specific ATC element, it will essentially return the state of that ATC element. When clicking the CF part of the status bar, it returns an error and never displays the status of CF in a window.

CarlB-dev avatar Jun 24 '22 21:06 CarlB-dev

Right. I was trying something new to clean up the work flows. Clicking the CF version on the bottom bar should provide the current CF config. I can definitely look into that. Then we can chat about what else you might need, ok?

DumpySquare avatar Jun 24 '22 21:06 DumpySquare

Hey @CarlB-dev. What do you want the solution to be here? Are you ok with the newer end state with less clutter or do you want the post declaration response displayed to the user?

DumpySquare avatar Sep 02 '22 15:09 DumpySquare

closing due to inactivity

DumpySquare avatar Mar 01 '23 15:03 DumpySquare