f4pga-arch-defs icon indicating copy to clipboard operation
f4pga-arch-defs copied to clipboard

Conda lock pull requests not running CI?

Open mithro opened this issue 2 years ago • 7 comments

See for example https://github.com/SymbiFlow/symbiflow-arch-defs/pull/2318

Seems to be missing kokoro and GitHub Actions run?

mithro avatar Nov 16 '21 17:11 mithro

@ajelinski and @acomodi

mithro avatar Nov 16 '21 17:11 mithro

I suppose the kokoro run is not triggered automatically because the author of the PR (bot) is not a member of the project - maybe we should automatically mark the PRs with kokoro:force-run label?

Missing GH-A CI is weird we have to check this

kgugala avatar Nov 16 '21 17:11 kgugala

https://github.com/peter-evans/create-pull-request/issues/48 <-- this one seems to explain the behaviour we see and it proposes workaround

kgugala avatar Nov 16 '21 17:11 kgugala

Can we use a deploy key to push as a Robot Account?

mithro avatar Nov 16 '21 20:11 mithro

@mithro Yeah, I think that we need to:

GitHub
symbiflow-robot has one repository available. Follow their code on GitHub.

acomodi avatar Nov 17 '21 08:11 acomodi

You're both correct @acomodi and @kgugala, the GH Actions token used currently is by design unable to trigger the CI. The PRs created will be able to do that if a PAT of SymbiFlow Robot (or any other account able to trigger kokoro with a PR) is used.

ajelinski avatar Nov 17 '21 08:11 ajelinski

Couple of links from a discussion with @acomodi;

  • https://github.com/puppetlabs/peter-evans-create-pull-request/blob/master/docs/concepts-guidelines.md#push-using-ssh-deploy-keys
  • https://github.com/mithro/openroad-actions/blob/main/push_to/action.yml
  • https://github.com/mithro/openroad-actions/commit/658b9c8199f7990b1cb36c5da01182e20c1dbdb8#diff-20e3a22481d805ead30527a5ee1e4669918f1e692cc321265ae11377c6936074
GitHub
A GitHub action to create a pull request for changes to your repository in the actions workspace - peter-evans-create-pull-request/concepts-guidelines.md at master · puppetlabs/peter-evans-create-p...
GitHub
Contribute to mithro/openroad-actions development by creating an account on GitHub.

mithro avatar Nov 18 '21 19:11 mithro