Felix Schlepper

Results 18 comments of Felix Schlepper

Thanks @ktf, dropped the cmake changes and replaced them by expressions.

@sawenzel thanks for the comments, dropped the sim changes in favour of the other PR and indeed using the configKeyValues is better.

Hi @wille10, the changes for TRD should be minimal. I added a configKeyValue as for TRD there wasn't one before, for now this only holds a single value but maybe...

> For the TRD reconstruction the parameters are stored in `GPU/GPUTracking/Definitions/GPUSettingsList.h`. Why is a new parameter class needed? Can it not be a wf option? @martenole sorry I pinged the...

> Hm, ok. The GPU settings are indeed not the place for that setting. And the configurable parameter classes that we have (for calibration and simulation) should not be abused...

> @f3sch sorry if I missed something, but why not defining a single key `withITS3` rather than doing this in different params? You can even add it as a member...

@shahor02 thanks, removed all other additions to configparams in favour of newly added GlobalParms.

Hi @shahor02, when you have time could you please take a look if you're fine with the proposed changes for the matching?