node-rsvg-prebuilt icon indicating copy to clipboard operation
node-rsvg-prebuilt copied to clipboard

Published 20 hours ago • verified publisher icon f3lang

Remove hard-coded PKG_CONFIG_PATH

Open LinusU opened this issue 5 years ago • 1 comments

This is preventing me from building on macOS 10.14.4, because it overwrites any other PKG_CONFIG_PATH that I have set in my environment.

On my system, which I've set up using what I believe to be just standard Homebrew, I don't need to have /opt/X11/lib/pkgconfig in my pkg config path. I do however need to have /usr/local/opt/libffi/lib/pkgconfig in there, which I had but it was overwritten by the removed lines.

I'm not sure why this line was added in the beginning (it was a long time ago in a fork), but I think that it's up to the end user to have a correctly configured pkg config installation. Trying to fix end user configuration errors is error-prone and can easily lead to more errors (as seen here ☺️)...

LinusU avatar May 07 '19 15:05 LinusU

ping @f3lang ☺️

LinusU avatar Dec 11 '19 20:12 LinusU