f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Fix filesystem linking

Open Meakk opened this issue 3 years ago • 1 comments
trafficstars

Fix #423

Meakk avatar Sep 20 '22 12:09 Meakk

More complex than what I expected. What matters is the libstdc++ version, not the GCC version.
For example in our CI, we are using clang 10 with libstdc++ 8 (for the sanitizer), so we actually need the link option to fs.

Meakk avatar Sep 20 '22 14:09 Meakk

Codecov Report

Merging #430 (6d56932) into master (a1d51cc) will increase coverage by 0.05%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #430      +/-   ##
==========================================
+ Coverage   94.88%   94.94%   +0.05%     
==========================================
  Files          91       91              
  Lines        4534     4568      +34     
==========================================
+ Hits         4302     4337      +35     
+ Misses        232      231       -1     
Impacted Files Coverage Δ
...xtensions/Rendering/vtkF3DRendererWithColoring.cxx 98.25% <0.00%> (-0.01%) :arrow_down:
library/VTKExtensions/Rendering/vtkF3DRenderer.cxx 99.74% <0.00%> (-0.01%) :arrow_down:
library/src/window_impl.cxx 100.00% <0.00%> (ø)
application/F3DOptionsParser.h 100.00% <0.00%> (ø)
application/F3DOptionsParser.cxx 97.93% <0.00%> (+0.05%) :arrow_up:
application/F3DStarter.cxx 98.10% <0.00%> (+0.19%) :arrow_up:
library/src/options.cxx 93.46% <0.00%> (+0.61%) :arrow_up:
application/F3DConfigFileTools.cxx 78.04% <0.00%> (+1.30%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Sep 27 '22 15:09 codecov[bot]