f3d
f3d copied to clipboard
Fix translucent objects when the texture is RGBA
Fix #332
Done, please review again @mwestphal
Codecov Report
Merging #341 (6519cb8) into master (d03f130) will decrease coverage by
0.02%. The diff coverage is100.00%.
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 94.80% 94.78% -0.03%
==========================================
Files 91 91
Lines 4487 4508 +21
==========================================
+ Hits 4254 4273 +19
- Misses 233 235 +2
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...ry/VTKExtensions/Readers/vtkF3DGenericImporter.cxx | 95.51% <100.00%> (-0.12%) |
:arrow_down: |
| ...rary/VTKExtensions/Readers/vtkF3DGenericImporter.h | 91.66% <0.00%> (-8.34%) |
:arrow_down: |
| library/src/loader_impl.cxx | 97.87% <0.00%> (-0.03%) |
:arrow_down: |
| library/src/window_impl.cxx | 100.00% <0.00%> (ø) |
|
| library/VTKExtensions/Rendering/vtkF3DRenderer.h | 83.33% <0.00%> (ø) |
|
| ...KExtensions/Rendering/vtkF3DRendererWithColoring.h | 58.82% <0.00%> (ø) |
|
| library/VTKExtensions/Rendering/vtkF3DRenderer.cxx | 99.74% <0.00%> (+<0.01%) |
:arrow_up: |
| ...xtensions/Rendering/vtkF3DRendererWithColoring.cxx | 98.26% <0.00%> (+0.04%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
So the multiplication issue is not fixed ?
So the multiplication issue is not fixed ?
Fixed here: https://gitlab.kitware.com/vtk/vtk/-/merge_requests/9467
The test will be fixed when the VTK MR will be merged
+1