f3d icon indicating copy to clipboard operation
f3d copied to clipboard

avoid nnnecessary reset escape sequences

Open snoyer opened this issue 3 months ago • 2 comments

Describe your changes

Refactor log coloring code to simplify the logic (at the cost of a few more LOC) and avoid emitting color reset sequences after messages where no color has been set.

Issue ticket number and link if any

Checklist for finalizing the PR

  • [x] I have performed a self-review of my code
  • [ ] I have added tests for new features and bugfixes
  • [ ] I have added documentation for new features
  • [ ] If it is a modifying the libf3d API, I have updated bindings
  • [ ] If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast. See here for more info.

snoyer avatar Dec 10 '25 13:12 snoyer

\ci full

snoyer avatar Dec 10 '25 13:12 snoyer

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.52%. Comparing base (6f4b055) to head (e43ffda). :warning: Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2708   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         141      141           
  Lines       12495    12501    +6     
=======================================
+ Hits        12061    12067    +6     
  Misses        434      434           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 10 '25 13:12 codecov[bot]

it broke a broken test, the math checks out :) (test was ensuring only the one wrong behavior this PR fixes and none of the correct ones)

I've fixed this coloring test to properly check all colors and also improved the other tests to check all levels.

snoyer avatar Dec 11 '25 04:12 snoyer