f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Update for importer animation changes in VTK

Open mwestphal opened this issue 3 weeks ago • 1 comments

Describe your changes

VTK recently changes the vtkImporter API for proper keyframe support. Adapt F3D usage of the Importer API to support different versions of VTK.

Also update vtk version in CI

Issue ticket number and link if any

Checklist for finalizing the PR

  • [ ] I have performed a self-review of my code
  • [ ] I have added tests for new features and bugfixes
  • [ ] I have added documentation for new features
  • [ ] If it is a modifying the libf3d API, I have updated bindings
  • [ ] If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast. See here for more info.

mwestphal avatar Dec 10 '25 07:12 mwestphal

You are modifying versions.json, please update the docker timestamp as well, this will generate new docker images and caches needed for CI.

github-actions[bot] avatar Dec 10 '25 07:12 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.58%. Comparing base (6f4b055) to head (cb1d9b2). :warning: Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2707      +/-   ##
==========================================
+ Coverage   96.52%   96.58%   +0.06%     
==========================================
  Files         141      142       +1     
  Lines       12495    12574      +79     
==========================================
+ Hits        12061    12145      +84     
+ Misses        434      429       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 13 '25 13:12 codecov[bot]

@Ni-g-3l @snoyer @Meakk please early review (I know CI is red)

mwestphal avatar Dec 14 '25 07:12 mwestphal

LGTM ! However we agree that this PR is only about updating Importer methods ? Not implement the timesteps filling ?

Ni-g-3l avatar Dec 14 '25 13:12 Ni-g-3l

LGTM ! However we agree that this PR is only about updating Importer methods ? Not implement the timesteps filling ?

Yes, absolutely, more MRs needed for proper timesteps implementation

mwestphal avatar Dec 14 '25 15:12 mwestphal