Fix collinear direction and up vector bug
Describe your changes
Fixes an issue where the model would not appear if the camera position to focal point vector and up vector are collinear.
Fixes a bug where the model would disappear after pressing '7' for the top view and then attempting to change the perspective by clicking and dragging the mouse.
Issue ticket number and link if any
#2048
Checklist for finalizing the PR
- [x] I have performed a self-review of my code
- [x] I have added tests for new features and bugfixes
- [ ] I have added documentation for new features
- [ ] If it is a modifying the libf3d API, I have updated bindings
- [ ] If it is a modifying the
.github/workflows/versions.json, I have updatedtimestamp
Continuous integration
Please check the checkbox of the CI you want to run, then push again on your branch.
- [x] Style checks
- [x] Fast CI
- [x] Coverage cached CI
- [x] Analysis cached CI
- [x] WASM docker CI
- [x] Android docker CI
- [x] macOS Intel cached CI
- [x] macOS ARM cached CI
- [x] Windows cached CI
- [x] Linux cached CI
- [x] Other cached CI
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.13%. Comparing base (
ef2a2e1) to head (b7f9836). Report is 9 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
+ Coverage 96.11% 96.13% +0.02%
==========================================
Files 130 130
Lines 11701 11769 +68
==========================================
+ Hits 11246 11314 +68
Misses 455 455
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Nice work @skusel , however I'll let you reach consensus with @snoyer before approving anything :)
@snoyer please review :)