f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Implements texture transforms

Open samoncrief opened this issue 7 months ago • 9 comments

Describe your changes

For issue #1643: https://github.com/f3d-app/f3d/issues/1643

Checklist for finalizing the PR

  • [x] I have performed a self-review of my code
  • [x] I have added tests for new features and bugfixes
  • [x] I have added documentation for new features
  • [ ] If it is a modifying the libf3d API, I have updated bindings
  • [ ] If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • [x] Style checks
  • [x] Fast CI
  • [x] Coverage cached CI
  • [x] Analysis cached CI
  • [x] WASM docker CI
  • [x] Android docker CI
  • [x] macOS Intel cached CI
  • [x] macOS ARM cached CI
  • [x] Windows cached CI
  • [x] Linux cached CI
  • [x] Other cached CI

samoncrief avatar May 30 '25 01:05 samoncrief

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar May 30 '25 01:05 github-actions[bot]

@mwestphal any other comment or can we merge that?

Meakk avatar Jun 05 '25 07:06 Meakk

@mwestphal any other comment or can we merge that?

nothing on my side, but CI has not run fully.

mwestphal avatar Jun 05 '25 07:06 mwestphal

Hi @samoncrief

Need any help moving forward ? You just need to check the checkboxes and push again.

mwestphal avatar Jun 10 '25 06:06 mwestphal

So it looks like the x to check needs to be x, not X.

Please try pushing again.

mwestphal avatar Jun 11 '25 11:06 mwestphal

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.15%. Comparing base (647ad39) to head (db409c3). Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2282      +/-   ##
==========================================
+ Coverage   96.11%   96.15%   +0.04%     
==========================================
  Files         130      130              
  Lines       11701    11752      +51     
==========================================
+ Hits        11246    11300      +54     
+ Misses        455      452       -3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 11 '25 14:06 codecov[bot]

@samoncrief need help with the styling ?

mwestphal avatar Jun 12 '25 05:06 mwestphal

@samoncrief need help with the styling ?

I'll be able to sit down and fix things soon, but I'm not sure how to handle the codecov part for transform2d_t throwing an error on parse and not using the format. Is there an existing test for the other types that handles this?

samoncrief avatar Jun 12 '25 13:06 samoncrief

@samoncrief need help with the styling ?

I'll be able to sit down and fix things soon, but I'm not sure how to handle the codecov part for transform2d_t throwing an error on parse and not using the format. Is there an existing test for the other types that handles this?

There a many examples in TestSDKOptionsIO.cxx I believe

mwestphal avatar Jun 12 '25 14:06 mwestphal

Thanks for your contribution @samoncrief ! Should I create an issue for https://github.com/f3d-app/f3d/pull/2282#discussion_r2128108215 or do you want to work on it right away ?

mwestphal avatar Jun 17 '25 16:06 mwestphal

Thanks for your contribution @samoncrief ! Should I create an issue for #2282 (comment) or do you want to work on it right away ?

https://github.com/f3d-app/f3d/issues/2301

mwestphal avatar Jun 18 '25 05:06 mwestphal

Thanks for your contribution @samoncrief ! Should I create an issue for #2282 (comment) or do you want to work on it right away ?

#2301

Go ahead and make it as a new issue for the next release, I'll probably take it then

samoncrief avatar Jun 18 '25 12:06 samoncrief