f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Animation indices

Open mwestphal opened this issue 7 months ago • 1 comments

Describe your changes

  • Implementation of animation-indices
  • Update all usages of old options
  • Deprecate old CLI and libf3d options
  • Updated doc

TODO:

  • Better error reporting with new VTK API
  • Animation behavior change doc

Behavior changes

  • Selecting an animation index that does not exist does not select the first animation instead
  • Cycling now cycle to "no animation selected"

Issue ticket number and link if any

Checklist for finalizing the PR

  • [x] I have performed a self-review of my code
  • [x] I have added tests for new features and bugfixes
  • [x] I have added documentation for new features
  • [x] If it is a modifying the libf3d API, I have updated bindings
  • [ ] If it is a modifying the .github/workflows/versions.json, I have updated timestamp

Continuous integration

Please check the checkbox of the CI you want to run, then push again on your branch.

  • [ ] Style checks
  • [x] Fast CI
  • [x] Coverage cached CI
  • [x] Analysis cached CI
  • [x] WASM docker CI
  • [x] Android docker CI
  • [x] macOS Intel cached CI
  • [x] macOS ARM cached CI
  • [x] Windows cached CI
  • [x] Linux cached CI
  • [x] Other cached CI

mwestphal avatar May 21 '25 19:05 mwestphal

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar May 21 '25 19:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 98.44961% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.14%. Comparing base (ac840b9) to head (e26f4f1). Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
library/src/animationManager.cxx 97.77% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2261      +/-   ##
==========================================
+ Coverage   96.06%   96.14%   +0.07%     
==========================================
  Files         131      131              
  Lines       11829    11924      +95     
==========================================
+ Hits        11364    11464     +100     
+ Misses        465      460       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 19 '25 06:06 codecov[bot]

Codecov seems to be struggling to update, actual coverage is higher to what they show.

mwestphal avatar Jun 27 '25 05:06 mwestphal

Codecov seems to be struggling to update, actual coverage is higher to what they show.

@Meakk

mwestphal avatar Jun 27 '25 06:06 mwestphal