f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Addition of --axesGrid option

Open ArchiePayne opened this issue 9 months ago • 8 comments

Added command line argument --axesGrid which maps to render.cubeAxis.enable.

Support showing the vtkCubeAxesActor within the viewport, matching to bounding box of the model.

Added application layer test for this option.

Issues #7

ArchiePayne avatar Mar 28 '25 11:03 ArchiePayne

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar Mar 28 '25 20:03 github-actions[bot]

Looks like your rebase/merge with master did not work as you expected, let me know if you need help with that :)

mwestphal avatar Mar 29 '25 13:03 mwestphal

Hey @ArchiePayne

Do you need help moving forward ?

mwestphal avatar Apr 21 '25 06:04 mwestphal

@mwestphal

As discussed on discord, we should hold this feature until the more advanced version from ParaView is being integrated to VTK. Please notify this thread when this happens and we can move forward :)

ArchiePayne avatar Apr 24 '25 18:04 ArchiePayne

vtkGridAxesActor3D has been added in VTK master

mwestphal avatar May 13 '25 09:05 mwestphal

@ArchiePayne

mwestphal avatar May 13 '25 09:05 mwestphal

Hi @ArchiePayne

Need any help moving forward ?

mwestphal avatar Jun 10 '25 06:06 mwestphal

Apologies I've only seen this @mwestphal, I will be looking into this again!

ArchiePayne avatar Jun 14 '25 12:06 ArchiePayne

@ArchiePayne I'm not sure what you did but the commit list/change list looks wrong.

Please rebase on the latest master and keep only your own commits.

mwestphal avatar Jun 28 '25 06:06 mwestphal

@ArchiePayne I'm not sure what you did but the commit list/change list looks wrong.

Please rebase on the latest master and keep only your own commits.

@mwestphal Apologies, unsure what I did but think I've fixed it now.

ArchiePayne avatar Jun 28 '25 12:06 ArchiePayne

Do you need help @ArchiePayne ? :)

mwestphal avatar Jul 05 '25 11:07 mwestphal

Do you need help @ArchiePayne ? :)

Yes please! :)

ArchiePayne avatar Jul 05 '25 11:07 ArchiePayne

If you read the CI results, I think it become quite clear :)

[ 36%] Building CXX object vtkext/private/module/CMakeFiles/vtkextPrivate.dir/vtkF3DSolidBackgroundPass.cxx.o
/__w/f3d/f3d/source/vtkext/private/module/vtkF3DRenderer.cxx: In member function 'void vtkF3DRenderer::ConfigureGridAxesUsingCurrentActors()':
/__w/f3d/f3d/source/vtkext/private/module/vtkF3DRenderer.cxx:778:14: error: unused variable 'bounds' [-Werror=unused-variable]
  778 |       double bounds[6] = { a, b, c, x, y, z };
      |              ^~~~~~
[ 37%] Building CXX object vtkext/private/module/CMakeFiles/vtkextPrivate.dir/vtkF3DUIObserver.cxx.o

Which is expected because this bounds var doesnt seems to be used. You can just remove it.

BTW you can enable F3D_STRICT_BUILD to trigger this locally I believe.

mwestphal avatar Jul 05 '25 11:07 mwestphal

Almost there, now you only need to disable the test if VTK doesnt have what you need, Ill leave a comment

mwestphal avatar Jul 06 '25 16:07 mwestphal

Alright, almosty there!

You can now enable all CI checkboces and push an empty commit :)

You also need to update the documentation for the new options.

mwestphal avatar Jul 07 '25 05:07 mwestphal

Codecov Report

Attention: Patch coverage is 97.82609% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.21%. Comparing base (06783c5) to head (df92a59). Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
vtkext/private/module/vtkF3DRenderer.cxx 97.77% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2100      +/-   ##
==========================================
+ Coverage   96.18%   96.21%   +0.03%     
==========================================
  Files         134      134              
  Lines       12114    12160      +46     
==========================================
+ Hits        11652    11700      +48     
+ Misses        462      460       -2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 07 '25 18:07 codecov[bot]

Nice!

To be complete this misses update to the doc in doc/user/OPTIONS.md

I have updated the documentation. Please let me know if the wording is okay

ArchiePayne avatar Jul 13 '25 18:07 ArchiePayne