Feature: Add getters for camera parameters #1419

[Schwarzemann]

Opening a new PR.

[github-actions[bot]]

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.80%. Comparing base (f59acec) to head (8cd2ea3).

Files with missing lines	Patch %	Lines
library/src/camera_impl.cxx	92.00%	2 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1663      +/-   ##
==========================================
- Coverage   95.81%   95.80%   -0.01%     
==========================================
  Files         125      125              
  Lines       10530    10555      +25     
==========================================
+ Hits        10089    10112      +23     
- Misses        441      443       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mwestphal]

@Schwarzemann any news on this ?

[Schwarzemann]

@Schwarzemann any news on this ?

Ah yes. Sorry work has been very busy lately. I will take care of it this week for sure.

[mwestphal]

Hi @Schwarzemann

Do you need any help moving forward ?

[Schwarzemann]

Hi @Schwarzemann

Do you need any help moving forward ?

Actually yes kind of. I would really appreciate it. I just can't wrap my head around the tests also can't seem to include vtkmath.h under TestSDKCamera.cxx so I can't use vtkMath::Dot2D.

[mwestphal]

Hi @Schwarzemann

Do you need any help moving forward ?

[Schwarzemann]

Hi @Schwarzemann

Do you need any help moving forward ?

Not right now thanks. I just have problems with time management nowadays.

[mwestphal]

Do you need any help moving forward @Schwarzemann ?

[mwestphal]

Hi @Schwarzemann

Do you need any help moving forward ?

[Schwarzemann]

Hi @Schwarzemann

Do you need any help moving forward ?

Sorry. I was supposed to push my latest changes but I haven't yet I will push as soon as possible and let you know.

[mwestphal]

Need any help @Schwarzemann ?

[mwestphal]

Hi @Schwarzemann

Are you around ? I can help and guide if needed :)

[Schwarzemann]

Hi @Schwarzemann

Are you around ? I can help and guide if needed :)

Hello. Sorry I've been very busy lately. Yes I would greatly appreciate the help. I am still having problems with the test. Everything else seems fine.

[mwestphal]

Hi @Schwarzemann Are you around ? I can help and guide if needed :)

Hello. Sorry I've been very busy lately. Yes I would greatly appreciate the help. I am still having problems with the test. Everything else seems fine.

I've left some comments. The main point is that we should not change the API. I can take care of that if we want to but for now lets just add the getters.

[Schwarzemann]

Hi @Schwarzemann Are you around ? I can help and guide if needed :)

Hello. Sorry I've been very busy lately. Yes I would greatly appreciate the help. I am still having problems with the test. Everything else seems fine.

I've left some comments. The main point is that we should not change the API. I can take care of that if we want to but for now lets just add the getters.

Okay yes most certainly I will take care of it tonight.