f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Refactor vector3_t #1645

Open Yogesh9000 opened this issue 1 year ago • 2 comments

refactored vector3_t and added a naive parse function

Yogesh9000 avatar Oct 05 '24 15:10 Yogesh9000

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar Oct 05 '24 15:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 99.47971% with 5 lines in your changes missing coverage. Please review.

Project coverage is 96.93%. Comparing base (544ae70) to head (2a0eef1). Report is 275 commits behind head on master.

Files with missing lines Patch % Lines
library/public/types.h 90.24% 4 Missing :warning:
application/F3DStarter.cxx 99.60% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1648      +/-   ##
==========================================
+ Coverage   96.85%   96.93%   +0.08%     
==========================================
  Files         108      106       -2     
  Lines        7691     8789    +1098     
==========================================
+ Hits         7449     8520    +1071     
- Misses        242      269      +27     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 05 '24 15:10 codecov[bot]

@Meakk @mwestphal have you reviewed the changes fo this pr

Yogesh9000 avatar Oct 22 '24 05:10 Yogesh9000

@Yogesh9000 any news on this ?

mwestphal avatar Nov 01 '24 11:11 mwestphal

@mwestphal been busy with job past few weeks, so haven't had time to work on it. would like to get back on it sometime but if it's urgent you can also take it up.

Yogesh9000 avatar Nov 01 '24 17:11 Yogesh9000

Please rebase your branch on master instead of merging

mwestphal avatar Nov 16 '24 09:11 mwestphal

here is a cleaned up rebase: https://github.com/mwestphal/f3d/tree/feature/add-a-direction-type

mwestphal avatar Nov 24 '24 06:11 mwestphal

here is a cleaned up rebase: https://github.com/mwestphal/f3d/tree/feature/add-a-direction-type

nice.

Yogesh9000 avatar Nov 24 '24 06:11 Yogesh9000