Quake MDL feature
Adds class vtkQuakeMDLImporter that reads .MDL files.
The class :
- Reads vertices and triangle data from the format to display a model.
- Reads a texture and texture coordinates from the format to display onto the model.
- Reads animations, stored as an array of vertices in the file, and saves them as a vector of polydata.
- Groups animations and displays them.
- Adds light sources to the scene.
Codecov Report
Attention: Patch coverage is 99.61832% with 1 line in your changes missing coverage. Please review.
Project coverage is 95.84%. Comparing base (
9e9123e) to head (c501d96). Report is 20 commits behind head on master.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| plugins/native/module/vtkF3DQuakeMDLImporter.cxx | 99.61% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
+ Coverage 95.75% 95.84% +0.09%
==========================================
Files 125 127 +2
Lines 10572 10834 +262
==========================================
+ Hits 10123 10384 +261
- Misses 449 450 +1
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@Youva any news on this ?
@Youva any news on this ?
Hi @Youva ! Looks like you are back. First you may want to rebase on the latest master :)
You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:!
You can find them in their respective directories: python, java, webassembly.
Looks like your merge did not go as expected. I'd strongly suggest using rebase instead of merge. Let me know if I can help (on discord or here).
Hi @Youva
Please resolve discussions you have adressed and let us know if this is ready for review.
Hi @Youva , please let us know if this is ready for review :)
Do you need any help or review to move forward @Youva ?
@Youva do you need any help moving forward ? This one is almost ready to merge :)
Looks like you have a small prettier issue. just run prettier -w /path/to/file.md locally to fix it.
Is this ready for review @Youva ? :)
I think it's ready for a review.
@malespiaut please review if you can :)
Hi @Youva , is this rdy for review ?
Animations will often skip frames on windows, not sure why.
Animations will often skip frames on windows, not sure why.
Slow to read maybe ?
Hi @Youva
Can we metrge this and improve on it ? We would like to release soon :)
I think everything else is fine.
Hi @Youva
Looks like there are a few review item not adressed yet :) It's ok, should we take over to adress them ?
Let us know :)
Alright, lets merge this, we will then improve on it iteratively.
Thanks for the contribution @Youva @malespiaut !