f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Quake MDL feature

Open Youva opened this issue 1 year ago • 1 comments

Adds class vtkQuakeMDLImporter that reads .MDL files.

The class :

  • Reads vertices and triangle data from the format to display a model.
  • Reads a texture and texture coordinates from the format to display onto the model.
  • Reads animations, stored as an array of vertices in the file, and saves them as a vector of polydata.
  • Groups animations and displays them.
  • Adds light sources to the scene.

Youva avatar Aug 25 '24 17:08 Youva

Codecov Report

Attention: Patch coverage is 99.61832% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.84%. Comparing base (9e9123e) to head (c501d96). Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
plugins/native/module/vtkF3DQuakeMDLImporter.cxx 99.61% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1591      +/-   ##
==========================================
+ Coverage   95.75%   95.84%   +0.09%     
==========================================
  Files         125      127       +2     
  Lines       10572    10834     +262     
==========================================
+ Hits        10123    10384     +261     
- Misses        449      450       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 24 '24 19:09 codecov[bot]

@Youva any news on this ?

mwestphal avatar Nov 01 '24 11:11 mwestphal

@Youva any news on this ?

mwestphal avatar Nov 24 '24 06:11 mwestphal

Hi @Youva ! Looks like you are back. First you may want to rebase on the latest master :)

mwestphal avatar Dec 17 '24 17:12 mwestphal

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar Dec 17 '24 23:12 github-actions[bot]

Looks like your merge did not go as expected. I'd strongly suggest using rebase instead of merge. Let me know if I can help (on discord or here).

mwestphal avatar Dec 18 '24 06:12 mwestphal

Hi @Youva

Please resolve discussions you have adressed and let us know if this is ready for review.

mwestphal avatar Dec 19 '24 07:12 mwestphal

Hi @Youva , please let us know if this is ready for review :)

mwestphal avatar Jan 05 '25 07:01 mwestphal

Do you need any help or review to move forward @Youva ?

mwestphal avatar Jan 28 '25 16:01 mwestphal

@Youva do you need any help moving forward ? This one is almost ready to merge :)

mwestphal avatar Feb 19 '25 07:02 mwestphal

Looks like you have a small prettier issue. just run prettier -w /path/to/file.md locally to fix it.

mwestphal avatar Feb 26 '25 07:02 mwestphal

Is this ready for review @Youva ? :)

mwestphal avatar Mar 01 '25 11:03 mwestphal

I think it's ready for a review.

Youva avatar Mar 01 '25 19:03 Youva

@malespiaut please review if you can :)

mwestphal avatar Mar 10 '25 06:03 mwestphal

Hi @Youva , is this rdy for review ?

mwestphal avatar Mar 24 '25 20:03 mwestphal

Animations will often skip frames on windows, not sure why.

Youva avatar Mar 27 '25 13:03 Youva

Animations will often skip frames on windows, not sure why.

Slow to read maybe ?

mwestphal avatar Mar 27 '25 14:03 mwestphal

Hi @Youva

Can we metrge this and improve on it ? We would like to release soon :)

mwestphal avatar Mar 29 '25 16:03 mwestphal

I think everything else is fine.

Youva avatar Mar 29 '25 16:03 Youva

Hi @Youva

Looks like there are a few review item not adressed yet :) It's ok, should we take over to adress them ?

Let us know :)

mwestphal avatar Mar 29 '25 17:03 mwestphal

Alright, lets merge this, we will then improve on it iteratively.

mwestphal avatar Mar 30 '25 10:03 mwestphal

Thanks for the contribution @Youva @malespiaut !

mwestphal avatar Mar 30 '25 10:03 mwestphal