Add proper parsing for all options types
Is your feature request related to a problem? Please describe. Options generation from .json file was added in https://github.com/f3d-app/f3d/pull/1471, but parsing/formating is pretty naive.
Check every single type (some have not been added yet, see https://github.com/f3d-app/f3d/issues/1570) and add proper parsing/formatting
- [x] bool
- [x] int
- [x] double
- [x] ratio
- [x] vector
- [x] string
- [ ] direction (not available yet)
- [ ] color (not available yet)
- [ ] path (not available yet)
- [ ] rgba_colormap (not available yet)
To add proper parsing/formating it is simply needed to:
- Implement proper parsing in options_tools::parse for this type
- Check that formating is correct in options_tools::format and improve it if needed
- Add testing in TestSDKOptions.cxx
starting with #1616
before we move forward with the more advanced types it would be useful to move the parse and format functions out of the .h.in file somewhere they can be picked up for coverage.
before we move forward with the more advanced types it would be useful to move the
parseandformatfunctions out of the.h.infile somewhere they can be picked up for coverage.
I agree, create an issue so we do not forget ? or take care of it ?
before we move forward with the more advanced types it would be useful to move the
parseandformatfunctions out of the.h.infile somewhere they can be picked up for coverage.
https://github.com/f3d-app/f3d/pull/2004/files
Finally Fixed by #2066