f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Add proper parsing for all options types

Open mwestphal opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Options generation from .json file was added in https://github.com/f3d-app/f3d/pull/1471, but parsing/formating is pretty naive.

Check every single type (some have not been added yet, see https://github.com/f3d-app/f3d/issues/1570) and add proper parsing/formatting

  • [x] bool
  • [x] int
  • [x] double
  • [x] ratio
  • [x] vector
  • [x] string
  • [ ] direction (not available yet)
  • [ ] color (not available yet)
  • [ ] path (not available yet)
  • [ ] rgba_colormap (not available yet)

To add proper parsing/formating it is simply needed to:

  • Implement proper parsing in options_tools::parse for this type
  • Check that formating is correct in options_tools::format and improve it if needed
  • Add testing in TestSDKOptions.cxx

mwestphal avatar Aug 20 '24 13:08 mwestphal

starting with #1616

snoyer avatar Sep 11 '24 07:09 snoyer

before we move forward with the more advanced types it would be useful to move the parse and format functions out of the .h.in file somewhere they can be picked up for coverage.

snoyer avatar Sep 15 '24 08:09 snoyer

before we move forward with the more advanced types it would be useful to move the parse and format functions out of the .h.in file somewhere they can be picked up for coverage.

I agree, create an issue so we do not forget ? or take care of it ?

mwestphal avatar Sep 15 '24 08:09 mwestphal

before we move forward with the more advanced types it would be useful to move the parse and format functions out of the .h.in file somewhere they can be picked up for coverage.

https://github.com/f3d-app/f3d/pull/2004/files

mwestphal avatar Feb 18 '25 06:02 mwestphal

Finally Fixed by #2066

mwestphal avatar Mar 25 '25 22:03 mwestphal