f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Add more option types

Open mwestphal opened this issue 1 year ago • 3 comments

Is your feature request related to a problem? Please describe. Options generation from .json file was added in https://github.com/f3d-app/f3d/pull/1471, but only a few types were added:

  • bool
  • int
  • double
  • ratio
  • double_vector
  • string

Lets add more types.

  • [ ] direction (specialisation of double_vector): https://github.com/f3d-app/f3d/issues/1645
  • [ ] color (specialisation of double_vector)
  • [ ] path (specialisation of string)
  • [ ] rgba_colormap (specialisation of double_vector)

To add a type it is needed to:

  • Add it to types.h with the correct API
  • Add a naive parse/format methods to options_tools.h.in
  • Use it for at least one option in options.json
  • Add testing in TestSDKOptions*

mwestphal avatar Aug 20 '24 13:08 mwestphal

Is this issue still open? If it is I would like to work on it.

Yogesh9000 avatar Oct 03 '24 18:10 Yogesh9000

Yes it is open! Lets discuss this one discord though :)

mwestphal avatar Oct 03 '24 19:10 mwestphal

sure lets discuss on discord

Yogesh9000 avatar Oct 03 '24 20:10 Yogesh9000

Good afternoon, I was wondering if this issue was still open? If so, is it possible I could work on it?

amannages avatar Nov 05 '24 20:11 amannages

It is still open but @Yogesh9000 is working on it in https://github.com/f3d-app/f3d/pull/1648

mwestphal avatar Nov 05 '24 22:11 mwestphal

fixed by the addition of colormap: https://github.com/f3d-app/f3d/pull/2061

mwestphal avatar Mar 17 '25 07:03 mwestphal