f3d icon indicating copy to clipboard operation
f3d copied to clipboard

C Bindings

Open parkerstafford opened this issue 1 year ago • 5 comments

Review for Kam

parkerstafford avatar May 29 '24 08:05 parkerstafford

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.58%. Comparing base (6168ad9) to head (1cd49fd). Report is 12 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1444   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         103      103           
  Lines        7701     7707    +6     
=======================================
+ Hits         7438     7444    +6     
  Misses        263      263           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 29 '24 08:05 codecov[bot]

FYI @Meakk

mwestphal avatar May 29 '24 09:05 mwestphal

You are modifying libf3d public API! :warning:Please update bindings accordingly:warning:! You can find them in their respective directories: python, java, webassembly.

github-actions[bot] avatar May 31 '24 01:05 github-actions[bot]

A few warnings and errors to fix in CI:

 cc1: warning: command-line option '-Woverloaded-virtual' is valid for C++/ObjC++ but not for C
cc1: error: command-line option '-Wsuggest-override' is valid for C++/ObjC++ but not for C [-Werror]
In file included from /__w/f3d/f3d/source/f3d/library/public/image.h:4,
                 from /__w/f3d/f3d/source/f3d/library/src/image_c_api.c:2:
/__w/f3d/f3d/source/f3d/library/public/exception.h:4:10: fatal error: stdexcept: No such file or directory
    4 | #include <stdexcept>
      |          ^~~~~~~~~~~
cc1: all warnings being treated a

But it looks good so far!

mwestphal avatar Jun 02 '24 10:06 mwestphal

hey @parkerstafford , need any help moving forward ?

mwestphal avatar Jul 13 '24 16:07 mwestphal

superseeded by https://github.com/f3d-app/f3d/pull/1892

mwestphal avatar Feb 22 '25 09:02 mwestphal