f3d icon indicating copy to clipboard operation
f3d copied to clipboard
verified publisher icon f3d-app

Removed recurrent logs from getReader

Open shambhupatil opened this issue 1 year ago • 1 comments

Moved debug logs from getReader() to loadScene() and loadGeometry() to reduce the same logs displayed many times.

shambhupatil avatar May 24 '24 22:05 shambhupatil

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.58%. Comparing base (0880e2e) to head (07595a4).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1434   +/-   ##
=======================================
  Coverage   96.58%   96.58%           
=======================================
  Files         103      103           
  Lines        7701     7706    +5     
=======================================
+ Hits         7438     7443    +5     
  Misses        263      263

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 24 '24 22:05 codecov[bot]

not sure what is hapening with codespell, ill take a look

mwestphal avatar May 25 '24 07:05 mwestphal

alright I fixed codespell, can you rebase on the last master @shambhupatil ?

mwestphal avatar May 26 '24 17:05 mwestphal

all good to me, can I merge @shambhupatil ?

mwestphal avatar May 26 '24 19:05 mwestphal