Remove double backslashes from file path when opening unsupported files.
I think CIs are failing because the file path should be displayed in quotes.
I think CIs are failing because the file path should be displayed in quotes.
Looks like it, yes. The failing test
1/1 Test #429: f3d::TestUnsupportedFileText .....***Failed Required regular expression not found. Regex=[.*unsupportedFile.dummy" is not a file of a supported file format
is defined here: https://github.com/f3d-app/f3d/blob/6133d0fa6189061f9fea453441dfbe086ba95087/application/testing/CMakeLists.txt#L877
You'll have to either:
- change the code to output the quotes
- change the test to not expect the quotes
I can't tell you which one is the way to go but @mwestphal and @Meakk will
You need to update the test, but it's a bit unclear to me where the quote was coming from in the first place.
Okay, I will look into why the quotes were there. Could you tell me how to update the tests?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.57%. Comparing base (
6133d0f) to head (5b3a651).
Additional details and impacted files
@@ Coverage Diff @@
## master #1428 +/- ##
=======================================
Coverage 96.57% 96.57%
=======================================
Files 103 103
Lines 7679 7679
=======================================
Hits 7416 7416
Misses 263 263
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.