f3d icon indicating copy to clipboard operation
f3d copied to clipboard

Implements GLTF Draco extension support

Open Meakk opened this issue 1 year ago • 3 comments

Fix #469

Waiting for https://gitlab.kitware.com/vtk/vtk/-/merge_requests/10884

Meakk avatar Feb 12 '24 21:02 Meakk

Codecov Report

Attention: Patch coverage is 88.59649% with 13 lines in your changes are missing coverage. Please review.

Project coverage is 96.49%. Comparing base (3f8eb1d) to head (69650c1). Report is 9 commits behind head on master.

Files Patch % Lines
plugins/draco/module/vtkF3DGLTFDocumentLoader.cxx 85.22% 13 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   96.59%   96.49%   -0.10%     
==========================================
  Files         138      146       +8     
  Lines        8446     8697     +251     
==========================================
+ Hits         8158     8392     +234     
- Misses        288      305      +17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 13 '24 09:02 codecov[bot]

@mwestphal it's ready to review, but cannot be merged before VTK MR

Meakk avatar Feb 13 '24 14:02 Meakk

ci is not clean

mwestphal avatar Feb 18 '24 14:02 mwestphal