rx-preferences icon indicating copy to clipboard operation
rx-preferences copied to clipboard

Updated reactive dependencies

Open davrukin opened this issue 4 years ago • 5 comments

Updated reactive dependencies (RxJava 2 -> 3, RxAndroid 2 -> 3, RxBin…ding 1 -> 4) and removed RxJava2Interop

I have a project in which I’m upgrading all the above listed libraries, and it also uses rx-preferences, which doesn’t have these libraries updated.

Compiled and installed test app, and it works on my Pixel 4.

davrukin avatar Jun 16 '20 06:06 davrukin

I’m not sure what you mean since there’s no pom.xml.

I’m also not sure why the Travis build is failing, since it’s working with no issues on my end.

davrukin avatar Jun 16 '20 19:06 davrukin

The groupId is defined in the root gradle.properties. The package name of all types will need to switch to a "3".

JakeWharton avatar Jun 16 '20 20:06 JakeWharton

Is there anything else that I may have missed?

davrukin avatar Jun 24 '20 20:06 davrukin

It looks like we may need to update the CI config to accomodate this change:

> Task :rx-preferences:mergeExtDexDebugAndroidTest FAILED
AGPBI: {"kind":"error","text":"Static interface methods are only supported starting with Android N (--min-api 24): io.reactivex.rxjava3.disposables.Disposable io.reactivex.rxjava3.disposables.Disposable.disposed()","sources":[{}],"tool":"D8"}

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':rx-preferences:mergeExtDexDebugAndroidTest'.
> Could not resolve all files for configuration ':rx-preferences:debugAndroidTestRuntimeClasspath'.
   > Failed to transform artifact 'rxjava.jar (io.reactivex.rxjava3:rxjava:3.0.4)' to match attributes {artifactType=android-dex, dexing-is-debuggable=true, dexing-min-sdk=9, org.gradle.usage=java-runtime-jars}
      > Execution failed for DexingTransform: /home/travis/.gradle/caches/modules-2/files-2.1/io.reactivex.rxjava3/rxjava/3.0.4/35debb1a7b43bc67e053084f662fa1086b4358aa/rxjava-3.0.4.jar.
         > Error while dexing.

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org

Deprecated Gradle features were used in this build, making it incompatible with Gradle 6.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/5.2.1/userguide/command_line_interface.html#sec:command_line_warnings

f2prateek avatar Jun 24 '20 21:06 f2prateek

I’m not sure what changes to make in the yml; are you able to?

davrukin avatar Jun 25 '20 17:06 davrukin