dart icon indicating copy to clipboard operation
dart copied to clipboard

issue #138: fix compilation error when using injection within an inne…

Open Luolc opened this issue 8 years ago • 6 comments

…r class

I have read the CI test and the diff is just the order of generated methods in Henson class.

Luolc avatar Nov 23 '16 19:11 Luolc

@Luolc let's move the discussion related to your PR here !

Yes we need the PR to be green. It's not about sorting the test methods (as tests methods should be orthogonal = independent from each other).

Here it's not the issue, or it's not phrased correctly: yes, you must swap gotoTest and gotoTestOne. If the order of these methods is random, ideally your PR should impose an order on the generated methods (but that could be a different issue).

stephanenicolas avatar Jan 04 '17 04:01 stephanenicolas

@stephanenicolas Get! I will try to fix the orders problem :) Thx for help!

Luolc avatar Jan 04 '17 04:01 Luolc

Np, and feel free to pressure us a bit to review the PR, we don't actively work on Dart 2 as if perfectly fits our need and we are quite busy with Toothpick, our new lib (and our other job tasks accessorily ;) ).

stephanenicolas avatar Jan 04 '17 05:01 stephanenicolas

@stephanenicolas hah I will mention you once I update the PR. Good luck for your new task :)

Luolc avatar Jan 04 '17 05:01 Luolc

@stephanenicolas green now :D plz have a check :)

Luolc avatar Jan 04 '17 07:01 Luolc

The PR is targeting an older version of Dart. @Luolc can you reproduce the issue you are trying to solve with the version 3.0.1?

dlemures avatar Jun 22 '18 21:06 dlemures