react-native-unity-view icon indicating copy to clipboard operation
react-native-unity-view copied to clipboard

Published 20 hours ago • verified publisher icon f111fei

Fixing black screen issue on iOS and build issue with typescript.

Open lmalave opened this issue 5 years ago • 1 comments

The following 2 changes were made:

  • Added a missing call to the completed() callback in createPlayer in UnityUtils.mm, to fix a black screen issue observed in iOS. The equivalent callback was already present in the Android code.

  • Set the typescript package version in package.json to 2.7.1 instead of ^2.7.1, to fix build issues that were apparently caused by later versions of the typescript package

The diff might look a little messy because we had originally made more changes in our fork, but then decided to revert to the July 19th commit f0140b97cfae65f49690c2b4ed54b9ab636a27d5 before the forks diverged, and then overwrote that with the latest from f111fei/react-native-unity-view master, plus the 2 small changes described above. To see what the true diff should be, please see the "two-dot" diff here: https://github.com/f111fei/react-native-unity-view/compare/master..pmfawkes:f111fei-pr-one-commit?expand=1

lmalave avatar Sep 27 '19 18:09 lmalave

Hi @f111fei We are using the fix that @lmalave has suggested and it would be great to get this merged into master. Is there any info you need to help make that happen?

galvogalvo avatar Oct 30 '19 18:10 galvogalvo