auto-dark-mode.nvim icon indicating copy to clipboard operation
auto-dark-mode.nvim copied to clipboard

Published 20 hours ago • verified publisher icon f-person

making `query_command` shell-agnostic

Open bugabinga opened this issue 1 year ago • 4 comments

fixes #18 query_command is now of type table so that vim.fn.jobstart does not use shell.

Tested on Windows 11 with nushell. Needs testing in:

  • linux
  • linux + sudo
  • macos
  • WSL

The code in parse_query_response now needs to handle a table, instead of a string, because the query_command cannot use pipes any more, which previously guaranteed that stdout consisted of one line.

bugabinga avatar Feb 27 '24 16:02 bugabinga

Hey @nekowinston! Does your commit fix the issues with the PR? Feel free to merge this if it works for you or close it otherwise :)

f-person avatar Apr 13 '24 20:04 f-person

It doesn't, my commit so far was a simple syntax error fix, the whole PR doesn't work for me in its current state. I meant to get back to this, but I currently don't have much time for FOSS work... 😓

nekowinston avatar Apr 13 '24 20:04 nekowinston

No worries, do as you wish whenever you wish with this one :)

f-person avatar Apr 13 '24 22:04 f-person

I have tested this branch on Windows, WSL and Fedora 40 and those work. Unfortunately, I have no NixOs system to test on.

bugabinga avatar May 03 '24 16:05 bugabinga